prevent infinite recursion when validating schemas #394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem:
Summary:
Infinite recursion is possible in src/utils.ts:mapDeep()
This will fix a few cases of "Uncaught RangeError: Maximum call stack size exceeded"
Detail:
Let's say I define a schema like this:
The Solution:
Summary:
To fix this we can modify the recursive function in question to track seen objects and return early if one is seen second time (or more).
Detail:
replace src/utils.ts:mapDeep() with crawl()
use a Set to detect reference cycles
Final note: Unfortunately json-schema-ref-parser has the exact same problem so we'll need to wait for APIDevTools/json-schema-ref-parser#231 to merge before this is really solved.